Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19268 )
Change subject: IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE ...................................................................... Patch Set 4: Code-Review+1 (3 comments) I agree with the feedback mentioned in the JIRA, that we should keep the same output format on all filesystems. http://gerrit.cloudera.org:8080/#/c/19268/4/docs/topics/impala_show.xml File docs/topics/impala_show.xml: http://gerrit.cloudera.org:8080/#/c/19268/4/docs/topics/impala_show.xml@a178 PS4, Line 178: > These are really long tables. Some comments in these docs mention that tabl I agree, I would prefer e.g. shortened/not real pathes and clean structure in docs rather than real examples. We could file a seperate Jira to clean up the tables http://gerrit.cloudera.org:8080/#/c/19268/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19268/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@207 PS4, Line 207: return "NONE"; nit: I think this should be public static final string, instead of inlined magic const. http://gerrit.cloudera.org:8080/#/c/19268/4/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/19268/4/tests/metadata/test_hms_integration.py@214 PS4, Line 214: result[tuple(id_parts)] = dict(zip(headers, stat_parts)) Nice! -- To view, visit http://gerrit.cloudera.org:8080/19268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd95f2d18b3980581788c92993b6d2f53504b5e0 Gerrit-Change-Number: 19268 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 09:54:02 +0000 Gerrit-HasComments: Yes
