Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18731 )
Change subject: IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/18731/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18731/11//COMMIT_MSG@13 PS11, Line 13: 1. Only support LEFT_OUTER_JOIN, RIGHT_OUTER_JOIN, INNER_JOIN; > cross join was rarely used, and the optimization was not verified. Sorry, I was a bit misleading here: I was thinking mainly about nested loop joins, not explicit CROSS JOINs in the query. Impala generates a nested loop join when there are no clear equality predicates on columns of the the two tables. An example is t1.key1 = t2.key1 OR t1.key2 = t2.key2 - because of the OR relationship Impala cannot use a straightforward hash join and creates a nested loop join node instead. Was wandering whether you optimization is applicable in that case. http://gerrit.cloudera.org:8080/#/c/18731/11/testdata/workloads/functional-planner/queries/PlannerTest/none-equal-predicate-push-down.test File testdata/workloads/functional-planner/queries/PlannerTest/none-equal-predicate-push-down.test: http://gerrit.cloudera.org:8080/#/c/18731/11/testdata/workloads/functional-planner/queries/PlannerTest/none-equal-predicate-push-down.test@5 PS11, Line 5: alltype > Yes, that's right. I will add relevant tests. Thanks. Thanks for rewriting them to use alltypes! I still think that it would be better to have some checks for stat filtering - rewriting any of these to function_parquet.alltypes would mean that the predicate should appear in the plan as dictionary/stat predicate. Another thing that came to my mind is a similar test for partition pruning - a test could use a partitioning column like month in alltypes, and the plans should show that some partitions are pruned. -- To view, visit http://gerrit.cloudera.org:8080/18731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ce23cbd7522a209c830504f329b972d67bc263 Gerrit-Change-Number: 18731 Gerrit-PatchSet: 15 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 15:15:41 +0000 Gerrit-HasComments: Yes
