[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19109 )
Change subject: IMPALA-11390: Describe formatted statement on materialized view should show the view definition ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19109/2/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java: http://gerrit.cloudera.org:8080/#/c/19109/2/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@547 PS2, Line 547: TODO Is it possible to consider creating a Jira task to track it? Just marking it in the code seems to be easy to ignore because many people don't know about it. http://gerrit.cloudera.org:8080/#/c/19109/2/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/19109/2/tests/metadata/test_ddl.py@888 PS2, Line 888: abort_on_error Minor question. Why do we set 'abort_on_error' QueryOption here? -- To view, visit http://gerrit.cloudera.org:8080/19109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie62be1ca6d74370bad4b32bb046df93027e6f651 Gerrit-Change-Number: 19109 Gerrit-PatchSet: 2 Gerrit-Owner: pengdou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: pengdou <[email protected]> Gerrit-Comment-Date: Wed, 07 Dec 2022 11:57:45 +0000 Gerrit-HasComments: Yes
