Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 )
Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19145/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19145/4/fe/src/main/java/org/apache/impala/service/Frontend.java@941 PS4, Line 941: private TLoadDataResp doLoadIcebergTableData(TLoadDataReq request) > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/19145/4/fe/src/main/java/org/apache/impala/service/Frontend.java@974 PS4, Line 974: > got it. Whops, yes, I did not notice that I left the second parameter there. Done. http://gerrit.cloudera.org:8080/#/c/19145/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19145/4/tests/query_test/test_iceberg.py@825 PS4, Line 825: > flake8: E502 the backslash is redundant between brackets Done -- To view, visit http://gerrit.cloudera.org:8080/19145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb Gerrit-Change-Number: 19145 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Dec 2022 13:50:38 +0000 Gerrit-HasComments: Yes
