Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 )
Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/19304/9/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19304/9/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@152 PS9, Line 152: if (returnOi_ != getInspector(retType_, true) > optional nit: Maybe it makes more sense to check if the returnOi_ is valid In the state it would be more logical to check it here, but t my other GenericUdf related review changes this are and uses initializeWrapper in different ways: https://gerrit.cloudera.org/#/c/19177/6/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java When using GenericUdf in "generic" way the return type is unknown beforehand and we know it only after initialize(). I would prefer to keep it this way in this patch possibly beatifying it after this patch is merged and the other is rebased. -- To view, visit http://gerrit.cloudera.org:8080/19304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30679045d6693ebd35718b6f1a22aaa4963c1e63 Gerrit-Change-Number: 19304 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 08 Dec 2022 12:38:36 +0000 Gerrit-HasComments: Yes
