Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 )
Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/19194/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19194/15//COMMIT_MSG@7 PS15, Line 7: SELECT > Thanks Qifan! Got it. The Hive model on a UDF execution privilege is represented by SELECT and INSERT or REFRESH. I am fine to your current design of following the Hive mode. http://gerrit.cloudera.org:8080/#/c/19194/15/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java: http://gerrit.cloudera.org:8080/#/c/19194/15/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java@347 PS15, Line 347: dbName_ = path.get(0); : functionName_.setDb(path.get(0)); : functionName_.setFunction(path.get(1)); > Hm, I am a bit confused here. Good point. Sorry I misread the || operator. http://gerrit.cloudera.org:8080/#/c/19194/15/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java@358 PS15, Line 358: // Need to set up 'dbName_', which in turn is used to set up 'db_name' of the : // TPrivilege in createTPrivilege() > Thanks Qifan! Done http://gerrit.cloudera.org:8080/#/c/19194/15/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/19194/15/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@579 PS15, Line 579: .error(accessError("functional"), : onUdf("functional", "f", TPrivilegeLevel.SELECT)) > Thanks Qifan! Got it. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/19194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e58ba30545ce169786aac279b00c8f6e09ae740 Gerrit-Change-Number: 19194 Gerrit-PatchSet: 15 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 12 Dec 2022 13:24:28 +0000 Gerrit-HasComments: Yes
