Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19268 )
Change subject: IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE ...................................................................... Patch Set 9: (2 comments) Looks good to me! http://gerrit.cloudera.org:8080/#/c/19268/9/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19268/9/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@208 PS9, Line 208: Unable to retrieve erasure coding policy nit. "Unable to retrieve erasure coding policy for distributed file system <xxx>. Return NONE". http://gerrit.cloudera.org:8080/#/c/19268/9/testdata/workloads/functional-query/queries/QueryTest/show.test File testdata/workloads/functional-query/queries/QueryTest/show.test: http://gerrit.cloudera.org:8080/#/c/19268/9/testdata/workloads/functional-query/queries/QueryTest/show.test@277 PS9, Line 277: $ERASURECODE_POLICY I notice this line bin/impala-config.sh: export HDFS_ERASURECODE_POLICY="RS-3-2-1024k" and just wonder if we should display the real policy"RS-3-2-1024k" instead. $ERASURECODE_POLICY seems very generic. -- To view, visit http://gerrit.cloudera.org:8080/19268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd95f2d18b3980581788c92993b6d2f53504b5e0 Gerrit-Change-Number: 19268 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Wed, 14 Dec 2022 01:12:17 +0000 Gerrit-HasComments: Yes
