Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 )
Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement ...................................................................... Patch Set 8: Code-Review+2 (1 comment) One tiny nit, otherwise looks good to me. Feel free the carry the +2. http://gerrit.cloudera.org:8080/#/c/19145/8/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java File fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: http://gerrit.cloudera.org:8080/#/c/19145/8/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@271 PS8, Line 271: format I mentioned the file path but this outputs the magic string as 'format'. Maybe include both the file name and the magic string and make it very clear what we show? I.e. "file is 'filePathForLike', magic string is 'magicString'" -- To view, visit http://gerrit.cloudera.org:8080/19145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb Gerrit-Change-Number: 19145 Gerrit-PatchSet: 8 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 Dec 2022 09:38:15 +0000 Gerrit-HasComments: Yes
