Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19352 )

Change subject: IMPALA-11796: Support structs in select list with Beeswax
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19352/1/be/src/service/query-result-set.cc
File be/src/service/query-result-set.cc:

http://gerrit.cloudera.org:8080/#/c/19352/1/be/src/service/query-result-set.cc@238
PS1, Line 238:       ::CollectionValueToJSON(*collection_val, type.type, 
item_tuple_desc, &writer);
nit: +2 indentation


http://gerrit.cloudera.org:8080/#/c/19352/1/be/src/service/query-result-set.cc@243
PS1, Line 243:       ::StructValToJSON(*struct_val, type, &writer);
nit: +2 indentation



--
To view, visit http://gerrit.cloudera.org:8080/19352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I579f7a6ab9bebda306a4acba80d423c1da4ea94c
Gerrit-Change-Number: 19352
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 14 Dec 2022 12:00:52 +0000
Gerrit-HasComments: Yes

Reply via email to