Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19358 )
Change subject: IMPALA-11790: Document the IMPALA-10660 shell option ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19358/1/docs/topics/impala_shell_options.xml File docs/topics/impala_shell_options.xml: http://gerrit.cloudera.org:8080/#/c/19358/1/docs/topics/impala_shell_options.xml@606 PS1, Line 606: <entry>--hs2_fp_format=<varname>HS2_FP_FORMAT</varname></entry> : <entry>hs2_fp_format=<varname>HS2_FP_FORMAT</varname></entry> > Do we need this line twice? The second one should be without the '--'. Corrected in the new patch. The first one is the command line option, the second is the config file option. See L548 for an example. -- To view, visit http://gerrit.cloudera.org:8080/19358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I402ea08cb3482a84234127c125539d96b4b1ed14 Gerrit-Change-Number: 19358 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 14 Dec 2022 14:50:29 +0000 Gerrit-HasComments: Yes
