Daniel Becker has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections
......................................................................
IMPALA-11717: Use rapidjson for printing collections
We have been using rapidjson to print structs but didn't use it to print
collections (arrays and maps).
This change introduces the usage of rapidjson to print collections for
both the HS2 and the Beeswax protocol.
The old code handling the printing of collections in raw-value.{h,cc} is
removed.
Testing:
- Ran existing EE tests
- Added EE tests with non-string and NULL map keys in
nested-map-in-select-list.test and map_null_keys.test.
Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165
Reviewed-on: http://gerrit.cloudera.org:8080/19309
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Daniel Becker <[email protected]>
---
A be/src/runtime/complex-value-writer.h
A be/src/runtime/complex-value-writer.inline.h
M be/src/runtime/raw-value.cc
M be/src/runtime/raw-value.h
M be/src/service/hs2-util.cc
M be/src/service/query-result-set.cc
M be/src/service/query-result-set.h
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
A testdata/workloads/functional-query/queries/QueryTest/map_null_keys.test
M
testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test
M tests/query_test/test_nested_types.py
12 files changed, 435 insertions(+), 143 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Daniel Becker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165
Gerrit-Change-Number: 19309
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
