Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 )
Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Looks good to me. We should ask Kurt/Abhishek/Andrew comment to make sure the name we pick does not confuse with existing term in admission control like slot or thread. http://gerrit.cloudera.org:8080/#/c/19366/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/19366/1/be/src/scheduling/admission-controller.h@546 PS1, Line 546: IntGauge* max_query_cpu_core_limit; > It's expected to show pool settings Thank you. -- To view, visit http://gerrit.cloudera.org:8080/19366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4c5ee519ce7c329b06ac821283e215a3560f525 Gerrit-Change-Number: 19366 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 16 Dec 2022 20:16:25 +0000 Gerrit-HasComments: Yes
