Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 )
Change subject: IMPALA-10399, IMPALA-11788: Reset Ranger policy repository in an E2E test ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Thanks for working on this! The workaround LGTM. http://gerrit.cloudera.org:8080/#/c/19373/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19373/2//COMMIT_MSG@15 PS2, Line 15: downloaded nit: download http://gerrit.cloudera.org:8080/#/c/19373/2/testdata/bin/setup-ranger.sh File testdata/bin/setup-ranger.sh: http://gerrit.cloudera.org:8080/#/c/19373/2/testdata/bin/setup-ranger.sh@25 PS2, Line 25: function setup-ranger { Thanks for extracting this! It also fixes IMPALA-11060. http://gerrit.cloudera.org:8080/#/c/19373/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19373/2/tests/authorization/test_ranger.py@754 PS2, Line 754: check_call([script_kill_ranger]) : check_call([script_create_test_config, '-create_ranger_policy_db']) : check_call([script_run_ranger]) : check_call([script_setup_ranger]) : # We need to wait for long enough for the policies set up by setup-ranger.sh to : # take effect. Executing "refresh authorization" as the user 'admin' does not work : # because the user 'admin' has not been granted the required privileges to execute : # the statement before the Ranger plugin is updated. : time.sleep(60) It might be better to do this in CustomClusterTestSuite.setup_method() before starting the Impala cluster. So we don't need to wait for 60s. https://github.com/apache/impala/blob/390a932064ba48c44e70e431f2c20e53beddd970/tests/common/custom_cluster_test_suite.py#L159 We can add an argument like reset_ranger (default to False) in with_args(): https://github.com/apache/impala/blob/390a932064ba48c44e70e431f2c20e53beddd970/tests/common/custom_cluster_test_suite.py#L105 and use it later in setup_method(). -- To view, visit http://gerrit.cloudera.org:8080/19373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff56ec03ceeb2912039241ea302f4bb8948d61f8 Gerrit-Change-Number: 19373 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 01:58:45 +0000 Gerrit-HasComments: Yes
