Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19378 )

Change subject: IMPALA:11808: Added support for reload event in catalogD
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@499
PS1, Line 499:   public static List<Long> fireReloadEventHelper(MetaStoreClient 
msClient, boolean isRefresh,
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@500
PS1, Line 500:                                                  List<String> 
partVals, String dbName, String tableName,
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@501
PS1, Line 501:                                                  Map<String, 
String> selfEventParams) throws TException {
line too long (105 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2509
PS1, Line 2509:         catalog_.invalidateTable(tbl.getTableName().toThrift(), 
tblWasRemoved, dbWasAdded);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2530
PS1, Line 2530:                         + "partition on table {} partition {} 
failed. Event processing cannot "
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2531
PS1, Line 2531:                         + "continue. Issue an invalidate 
metadata command to reset the event "
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2548
PS1, Line 2548:                         + "cannot continue. Issue an invalidate 
metadata command to reset "
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/19378/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6357
PS1, Line 6357:         LOG.error(String.format(HMS_RPC_ERROR_FORMAT_STR, 
"refreshTable") + e.getMessage());
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/19378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62d58837d356dc2113f3c0904228ac9de484136
Gerrit-Change-Number: 19378
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Mon, 19 Dec 2022 17:24:17 +0000
Gerrit-HasComments: Yes

Reply via email to