Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19183 )
Change subject: IMPALA-11713: Switch to C++17 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19183/4/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19183/4/be/CMakeLists.txt@48 PS4, Line 48: SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=c++17") > I wouldn't expect c++14 vs c++17 with the same compiler to have any perform I will run one and post the results on this review (or incorporate the results into the commit message). -- To view, visit http://gerrit.cloudera.org:8080/19183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadac41817fe5eaaa469a5f0e9f94056a409c14b9 Gerrit-Change-Number: 19183 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 23:01:39 +0000 Gerrit-HasComments: Yes
