Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test ...................................................................... Patch Set 1: (2 comments) Thank you for the review Gergo and Noemi! I am carrying over the +1s. http://gerrit.cloudera.org:8080/#/c/19385/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19385/1//COMMIT_MSG@10 PS1, Line 10: referrence > nit: reference Done http://gerrit.cloudera.org:8080/#/c/19385/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test: http://gerrit.cloudera.org:8080/#/c/19385/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test@121 PS1, Line 121: has fewer columns (1) than the SELECT / VALUES clause returns (4) > nit: we could add a "row_regex:Analysis..." to be more precise and just ign Done -- To view, visit http://gerrit.cloudera.org:8080/19385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3 Gerrit-Change-Number: 19385 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 21 Dec 2022 17:42:15 +0000 Gerrit-HasComments: Yes
