Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19391 )
Change subject: IMPALA-11812: Deduplicate column list in hmsPartitions ...................................................................... IMPALA-11812: Deduplicate column list in hmsPartitions A list of HMS Partitions will be created in many workloads in catalogd, e.g. table loading, bulk altering partitions by ComputeStats or AlterTableRecoverPartitions, etc. Currently, each of hmsPartition hold a unique list of column schema, i.e. a List<FieldSchema>. This results in lots of FieldSchema instances if the table is wide and lots of partitions need to be loaded/operated. Though the strings of column names and comments are interned. The FieldSchema objects could still occupy the majority of the heap. See the histogram in JIRA description. In fact, the hmsPartition instances of a table can share the column schema (either from the hmsTable or other hmsPartition instances) since Impala doesn't respect the partition level schema. This patch add codes to deduplicate column list in StorageDescriptor of hmsPartitions. Also add some progress logs in batch HMS operations to improve supportability. Tests: - Ran CORE tests Change-Id: I511ecca0ace8bea4c24a19a54fb0a75390e50c4d --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java 4 files changed, 55 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19391/2 -- To view, visit http://gerrit.cloudera.org:8080/19391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I511ecca0ace8bea4c24a19a54fb0a75390e50c4d Gerrit-Change-Number: 19391 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]>
