Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 )
Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table ...................................................................... Patch Set 13: Code-Review+1 (2 comments) LGTM http://gerrit.cloudera.org:8080/#/c/18953/13/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/18953/13/common/thrift/JniCatalog.thrift@225 PS13, Line 225: 1: optional list<CatalogObjects.TColumn> columns If no new columns are added, i.e. all columns exist, I think we don't need to trigger catalogd RPCs since there are nothing catalogd needs to do. However, this is an optimization. We can do it in a separate JIRA. http://gerrit.cloudera.org:8080/#/c/18953/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18953/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1036 PS13, Line 1036: In AlterTableAddColsStmt, there is remove for columns. : // May cause columns to be empty. nit: columns could be ignored/cleared in AlterTableAddColsStmt -- To view, visit http://gerrit.cloudera.org:8080/18953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82590e5372e881f2e81d4ed3dd0d32a2d3ddb517 Gerrit-Change-Number: 18953 Gerrit-PatchSet: 13 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 11:29:49 +0000 Gerrit-HasComments: Yes
