Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 )
Change subject: IMPALA-10893: Use old schema during iceberg time travel. ...................................................................... Patch Set 2: (5 comments) Left a few nit comments, otherwise the change looks great! http://gerrit.cloudera.org:8080/#/c/19380/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19380/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1309 PS2, Line 1309: timeTravelTable.readSchema(); Could it be part of the constructor of IcebergTimeTravelTable? http://gerrit.cloudera.org:8080/#/c/19380/2/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java: http://gerrit.cloudera.org:8080/#/c/19380/2/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@95 PS2, Line 95: , null) Maybe we could overload Analyzer.resolvePath() so we wouldn't need to change unrelated code paths. http://gerrit.cloudera.org:8080/#/c/19380/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/19380/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@471 PS2, Line 471: so we : // cannot check it yet. "so we cannot check if the table supports time travel"? http://gerrit.cloudera.org:8080/#/c/19380/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19380/2/tests/authorization/test_ranger.py@1844 PS2, Line 1844: nit: +2 indent http://gerrit.cloudera.org:8080/#/c/19380/2/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19380/2/tests/query_test/test_iceberg.py@456 PS2, Line 456: # FIXME use new ts?? Please resolve this. Does the following query work? SELECT * FROM {tbl} FOR SYSTEM_TIME AS OF <ts_5> MINUS SELECT *, NULL FROM {tbl} FOR SYSTEM_TIME AS OF <ts_4> Or since the second subquery has NULL the whole query returns every row? Then maybe we could SELECT i FROM {tbl} FOR SYSTEM_TIME AS OF <ts_5> MINUS SELECT i FROM {tbl} FOR SYSTEM_TIME AS OF <ts_4> -- To view, visit http://gerrit.cloudera.org:8080/19380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cbef6e20bbb567e517744fb1f34d880970399ab Gerrit-Change-Number: 19380 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 16:57:08 +0000 Gerrit-HasComments: Yes
