Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19214 )
Change subject: IMPALA-7969: Always admit trivial queries immediately ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19214/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19214/4//COMMIT_MSG@29 PS4, Line 29: Also, we restrict the parallelism of execution of the trivial : query, each resource pool can execute no more than three trivial : queries at the same time. If the maximum parallelism is reached, : the admission controller would try to admit the trivial query : via normal process. What happens when you have multiple coordinators? Since the trivial queries are a subset of coordinator only queries should we also include #coordinators in the calculation. So basically something like X trivial queries per coordinator per resource pool and total X*N trivial queries per resource pool? We will also have to enforce it so that each coordinator can only execute X trivial queries per resource pool. -- To view, visit http://gerrit.cloudera.org:8080/19214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a729764e3055d7eb11900c96c82ff53eb261f91 Gerrit-Change-Number: 19214 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:43:52 +0000 Gerrit-HasComments: Yes
