Hello Tamas Mate, Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19221

to look at the new patch set (#4).

Change subject: IMPALA-11620: Enable setting 'write.format.default'
......................................................................

IMPALA-11620: Enable setting 'write.format.default'

Enable setting 'write.format.default' to a different file format
than what the table already contains.

Before IMPALA-10610 Iceberg tables with mixed-format data files were not
supported.
We used 'write.format.default' to determine the file format of the
table, which was only a temporary workaround. Because of this we did not
allow changing this table property if the table already contained
different table formats. E.g. we did not allow modifying
'write.format.default' to PARQUET if the table already contained ORC
files, because it would have made the table unreadable for Impala.
Since IMPALA-10610 'write.format.default' is not used to determine the
Iceberg table's format anymore, so we can allow changing it.

This table property change is not synchronized between HMS and Iceberg
metadata files in case of true external Hive Catalog tables.
See IMPALA-11710.

Testing:
- E2E test in iceberg-alter.test

Change-Id: I22d0a8a18fce99015fcfe1fd15cb4a4d4c2deaec
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
2 files changed, 3 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/19221/4
--
To view, visit http://gerrit.cloudera.org:8080/19221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22d0a8a18fce99015fcfe1fd15cb4a4d4c2deaec
Gerrit-Change-Number: 19221
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>

Reply via email to