Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19364 )
Change subject: IMPALA-11778: Printing maps may produce invalid json ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/19364/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19364/2//COMMIT_MSG@20 PS2, Line 20: : Hive has the same behaviour. Can you make it clearer that Hive also produces invalid JSON? http://gerrit.cloudera.org:8080/#/c/19364/2/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/19364/2/be/src/service/query-options.h@284 PS2, Line 284: REGULAR I would consider this advanced (should affect very few users) -- To view, visit http://gerrit.cloudera.org:8080/19364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1820036a1c614c34ae5d70ac4fe79a992c9bce3a Gerrit-Change-Number: 19364 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Jan 2023 15:03:02 +0000 Gerrit-HasComments: Yes
