Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19415/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/19415/1/be/src/codegen/llvm-codegen.cc@2005 PS1, Line 2005: > This newline only needed if debug_mode is True? Maybe move it to the branch Thanks, seems the LOG can remove the redundant newline, but agree that it is good to put it in the debug branch. Done. -- To view, visit http://gerrit.cloudera.org:8080/19415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa Gerrit-Change-Number: 19415 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 12 Jan 2023 01:09:57 +0000 Gerrit-HasComments: Yes
