Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 )
Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/19412/4/testdata/bin/rewrite-iceberg-metadata.py File testdata/bin/rewrite-iceberg-metadata.py: http://gerrit.cloudera.org:8080/#/c/19412/4/testdata/bin/rewrite-iceberg-metadata.py@38 PS4, Line 38: def generate_new_path(prefix, file_path): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19412/4/testdata/bin/rewrite-iceberg-metadata.py@44 PS4, Line 44: ) flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19412/4/testdata/bin/rewrite-iceberg-metadata.py@52 PS4, Line 52: s flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19412/4/testdata/bin/rewrite-iceberg-metadata.py@65 PS4, Line 65: a flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19412/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19412/4/tests/query_test/test_iceberg.py@788 PS4, Line 788: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/19412/4/tests/query_test/test_iceberg.py@788 PS4, Line 788: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/19412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b9208f25552012cc1ab16fa60a819dd5a683d9 Gerrit-Change-Number: 19412 Gerrit-PatchSet: 4 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:30:21 +0000 Gerrit-HasComments: Yes
