Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 )
Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite ...................................................................... Patch Set 7: (3 comments) Thank you for reverting the 'SkipIf' annotations in the avro and mixed format tests, and also for the path rewrites. 'Location' also needs to be rewritten. http://gerrit.cloudera.org:8080/#/c/19412/7/testdata/bin/rewrite-iceberg-metadata.py File testdata/bin/rewrite-iceberg-metadata.py: http://gerrit.cloudera.org:8080/#/c/19412/7/testdata/bin/rewrite-iceberg-metadata.py@35 PS7, Line 35: pathes nit: paths http://gerrit.cloudera.org:8080/#/c/19412/7/testdata/bin/rewrite-iceberg-metadata.py@40 PS7, Line 40: pathes nit: paths http://gerrit.cloudera.org:8080/#/c/19412/7/testdata/bin/rewrite-iceberg-metadata.py@97 PS7, Line 97: prefix + metadata['location'] generate_new_path(prefix, metadata['location']) -- To view, visit http://gerrit.cloudera.org:8080/19412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b9208f25552012cc1ab16fa60a819dd5a683d9 Gerrit-Change-Number: 19412 Gerrit-PatchSet: 7 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Jan 2023 12:52:36 +0000 Gerrit-HasComments: Yes
