Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19423 )
Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG@9 PS1, Line 9: need > nit: needs Done http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG@10 PS1, Line 10: implement > nit: implements Done http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG@19 PS1, Line 19: - Checked that manifest caching works through debug logging. > Does it works in case of HadoopTables and Catalogs as well? I believe manifest caching is only touched if table is loaded using IcebergHadoopCatalog or IcebergHiveCatalog. http://gerrit.cloudera.org:8080/#/c/19423/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/19423/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1067 PS1, Line 1067: non-existent. > nit. non-existent or doesn't exist Done -- To view, visit http://gerrit.cloudera.org:8080/19423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a60a700d2ae6302dfe395d1ef602e6b1d821888 Gerrit-Change-Number: 19423 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 18 Jan 2023 19:08:18 +0000 Gerrit-HasComments: Yes
