Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19432 )
Change subject: IMPALA-11807: Rewrite iceberg metadata if not on hdfs ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19432/1/testdata/bin/load-test-warehouse-snapshot.sh File testdata/bin/load-test-warehouse-snapshot.sh: http://gerrit.cloudera.org:8080/#/c/19432/1/testdata/bin/load-test-warehouse-snapshot.sh@120 PS1, Line 120: ${IMPALA_HOME}/testdata/bin/rewrite-iceberg-metadata.py "${WAREHOUSE_LOCATION_PREFIX}" \ > So this removes the authority portion so we just have a path, even if WAREH Yes, exactly http://gerrit.cloudera.org:8080/#/c/19432/1/testdata/bin/load-test-warehouse-snapshot.sh@121 PS1, Line 121: $(find ${SNAPSHOT_STAGING_DIR}${TEST_WAREHOUSE_DIR}/iceberg_test -name "metadata") > For future updates, I think it would be safe to search all files instead of Done -- To view, visit http://gerrit.cloudera.org:8080/19432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic04c5abdd42cb0c1cf5abd310b06c39cf8cd64ba Gerrit-Change-Number: 19432 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Fri, 20 Jan 2023 17:21:57 +0000 Gerrit-HasComments: Yes
