Hello Yida Wu, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19437
to look at the new patch set (#2).
Change subject: IMPALA-11857: Connect join build fragment to join in graphical
plan
......................................................................
IMPALA-11857: Connect join build fragment to join in graphical plan
When support was added for join build sink, the plan JSON and plan
rendering logic were not updated to handle the new sink type. As a
result, the linkage from the join build fragment to its corresponding
join node were not expressed in the JSON and build fragments nodes were
rendered as orphaned.
This change adds a new JSON join_build_target field to join build
fragments and connects the build fragment to the join with a green dashed
line similar to the red dashed line used for data sender fragments.
Also changed the SVG fill type to 'none' for exchange edges to avoid
rendering a black triangle if the right child was an exchange as in the
join build case.
Testing:
- Manual testing with TPCH queries and reviewing rendered plan diagrams
Change-Id: I80af977e5c5e869268d3ee68fafe541adadc239d
---
M be/src/service/impala-http-handler.cc
M www/query_plan.tmpl
2 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19437/2
--
To view, visit http://gerrit.cloudera.org:8080/19437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80af977e5c5e869268d3ee68fafe541adadc239d
Gerrit-Change-Number: 19437
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
