Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 )
Change subject: IMPALA-11856: Use POST requests to set log level ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/19199/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19199/19//COMMIT_MSG@11 PS19, Line 11: where POST requests must include a : csrf_token field in their post with the random value from the cookie - : or a custom header. > This means that POST requests will always need csrf_token or X-requested-by Someone POSTing just to read a page would have been possible, but seems unlikely. curl requires a body when POSTing, and browsers require a form, so they would have had to jump through hoops to do it. http://gerrit.cloudera.org:8080/#/c/19199/19/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java: http://gerrit.cloudera.org:8080/#/c/19199/19/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@414 PS19, Line 414: does nothing > This also returns an error like the previous block, right? Yeah, I'll update the comment to match. http://gerrit.cloudera.org:8080/#/c/19199/19/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@425 PS19, Line 425: new WebClient(TEST_USER_1, TEST_PASSWORD_1); > just an idea to reduce noise: WebClient could have a reset function or a re Doing that correctly turned out to be tricky. I had to recreate the internal client anyway because it doesn't have public methods that allow sufficient cleanup. I think this is clear enough. -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 19 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 27 Jan 2023 16:54:42 +0000 Gerrit-HasComments: Yes
