Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19460 )
Change subject: IMPALA-11883: Calculate erasure-coded bytes read directly ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19460/1/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/19460/1/be/src/runtime/io/scan-range.cc@254 PS1, Line 254: if (is_erasure_coded_) { I wonder if we should do this in HdfsFileReader at https://github.com/apache/impala/blob/master/be/src/runtime/io/hdfs-file-reader.cc#L236 to avoid counting ReadDataCache. That's closer to where we were doing hdfsFileGetReadStatistics too. -- To view, visit http://gerrit.cloudera.org:8080/19460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c Gerrit-Change-Number: 19460 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 30 Jan 2023 22:19:24 +0000 Gerrit-HasComments: Yes
