Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 )
Change subject: IMPALA-11865: Set thread names for Java thread pools ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java@447 PS2, Line 447: new ThreadFactoryBuilder().setDaemon(true) > Oh, I missed that. Let me revert and we can do it right. I'm going off https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Executors.html#defaultThreadFactory(), which notes "Each new thread is created as a non-daemon thread". -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 31 Jan 2023 00:11:47 +0000 Gerrit-HasComments: Yes
