Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19429 )

Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in 
resolvePathWithMasking
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19429/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
File 
testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test:

http://gerrit.cloudera.org:8080/#/c/19429/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test@63
PS6, Line 63: # Test resolving nested columns in expanding star expression.
Can you add a test with EXPAND_COMPLEX_TYPES=1? It should return an analysis 
for now, but it is something that should work with column mask on ID once 
https://gerrit.cloudera.org/#/c/19322/ is merged



--
To view, visit http://gerrit.cloudera.org:8080/19429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77
Gerrit-Change-Number: 19429
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 31 Jan 2023 09:27:17 +0000
Gerrit-HasComments: Yes

Reply via email to