Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 )
Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19416/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/19416/1/fe/src/main/java/org/apache/impala/catalog/Table.java@191 PS1, Line 191: TRUE > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#Languag Thank you for the explanation, I was not aware that the entire external.table.purge property was introduced to handle migrated tables. Hive seems to set it to false by default, should we follow this direction? It sounds more natural to me to keep it false by default and set it to true for edge cases like migrated table or Iceberg HiveCatalog tables. Or we could move this property to IcebergTable. https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L3660 -- To view, visit http://gerrit.cloudera.org:8080/19416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2649dd38fbe050044817d6c425ef447245aa2829 Gerrit-Change-Number: 19416 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 01 Feb 2023 09:43:52 +0000 Gerrit-HasComments: Yes
