Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19417 )

Change subject: IMPALA-11823: Add more items to Impala web UI queries page
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19417/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

http://gerrit.cloudera.org:8080/#/c/19417/2/be/src/runtime/coordinator.cc@1429
PS2, Line 1429: UpdatePeakMemUsageAndBytesRead
nit: Maybe we can use the existing Coordinator::ComputeQueryResourceUtilization 
to get the total resource usage of a query. Besides, do you think the total 
bytes_sent metric is also worth adding to the web page?



--
To view, visit http://gerrit.cloudera.org:8080/19417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19c75461a6405025fa433ae84d2c94d013fcaacb
Gerrit-Change-Number: 19417
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Thu, 02 Feb 2023 14:17:34 +0000
Gerrit-HasComments: Yes

Reply via email to