Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19475 )
Change subject: IMPALA-11886: Data cache should support asynchronous writes ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache-test.cc File be/src/runtime/io/data-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache-test.cc@104 PS1, Line 104: /// before any lookup when running test case in async write mode. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache.h File be/src/runtime/io/data-cache.h: http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache.h@499 PS1, Line 499: /// Limit of the total buffer size used by asynchronous store tasks, when the current line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache.cc@117 PS1, Line 117: DEFINE_int32(data_cache_num_write_threads, 0, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache.cc@122 PS1, Line 122: DEFINE_string(data_cache_write_buffer_limit, "1GB", line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/runtime/io/data-cache.cc@895 PS1, Line 895: int64_t buffer_limit = ParseUtil::ParseMemSpec(FLAGS_data_cache_write_buffer_limit, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/util/impalad-metrics.cc File be/src/util/impalad-metrics.cc: http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/util/impalad-metrics.cc@84 PS1, Line 84: const char* ImpaladMetricKeys::IO_MGR_REMOTE_DATA_CACHE_ACTIVE_BUFFER_BYTES = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/util/impalad-metrics.cc@86 PS1, Line 86: const char* ImpaladMetricKeys::IO_MGR_REMOTE_DATA_CACHE_STORE_TASKS_CREATED = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19475/1/be/src/util/impalad-metrics.cc@88 PS1, Line 88: const char* ImpaladMetricKeys::IO_MGR_REMOTE_DATA_CACHE_OUT_OF_BUFFER_LIMIT_BYTES = line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/19475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I878f7486d485b6288de1a9145f49576b7155d312 Gerrit-Change-Number: 19475 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 06 Feb 2023 12:21:10 +0000 Gerrit-HasComments: Yes
