Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19471 )
Change subject: IMPALA-11081: Fix incorrect results in partition key scan ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/19471/6/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/19471/6/tests/query_test/test_queries.py@366 PS6, Line 366: def test_partition_key_scans_with_avro_multiple_blocks_table(self): Thanks for adding this test. We don't need to write individual test for each file format. Currently this method only has 'self' as the parameter. If we add 'vector' in the parameter list, the test will run on all test vectors so include all file formats. https://github.com/apache/impala/blob/32536ba25869ea621bdb82bb79a520a115e02cdd/tests/conftest.py#L221-L222 We will need to skip non-hdfs formats like kudu and hbase in add_test_dimensions(). TestPartitionKeyScans.add_test_dimensions() is an example. Since we already have the alltypes table generated for all formats, I suggest augmenting this test to be able to run on all formats, including compressed text formats like text/gzip. The actual file format string can be extracted from the vector by vector.get_value('table_format').file_format The compression can be extracted by vector.get_value('table_format').compression_codec https://github.com/apache/impala/blob/32536ba25869ea621bdb82bb79a520a115e02cdd/tests/common/test_dimensions.py#L41-L42 -- To view, visit http://gerrit.cloudera.org:8080/19471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17331ed6c26a747e0509dcbaf427cd52808943b1 Gerrit-Change-Number: 19471 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 09:42:35 +0000 Gerrit-HasComments: Yes
