Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19472 )
Change subject: IMPALA-10804: [DOCS] Document spill to remote storage ...................................................................... Patch Set 2: (6 comments) Thanks for the update. On second thought, I think the hdfs example could be better to use ip_address:port_num. http://gerrit.cloudera.org:8080/#/c/19472/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19472/2//COMMIT_MSG@9 PS2, Line 9: Incorporate feedback received. This message should be supposed to reply in gerrit instead of in the commit message. http://gerrit.cloudera.org:8080/#/c/19472/2/docs/topics/impala_disk_space.xml File docs/topics/impala_disk_space.xml: http://gerrit.cloudera.org:8080/#/c/19472/2/docs/topics/impala_disk_space.xml@406 PS2, Line 406: ipaddr:port Maybe it is good to use the same format as above: ip_address:port_num http://gerrit.cloudera.org:8080/#/c/19472/2/docs/topics/impala_disk_space.xml@428 PS2, Line 428: ipaddr:port Same as above. http://gerrit.cloudera.org:8080/#/c/19472/2/docs/topics/impala_disk_space.xml@431 PS2, Line 431: ipaddr:port Same as above. http://gerrit.cloudera.org:8080/#/c/19472/2/docs/topics/impala_disk_space.xml@434 PS2, Line 434: ipaddr:port Same as above. http://gerrit.cloudera.org:8080/#/c/19472/2/docs/topics/impala_disk_space.xml@450 PS2, Line 450: ipaddr On second thought, ip_address might be better. -- To view, visit http://gerrit.cloudera.org:8080/19472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3efb2ffcc06cdbe69845c6dc4cf03d9f2e3dcabc Gerrit-Change-Number: 19472 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 21:30:30 +0000 Gerrit-HasComments: Yes
