Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19481 )
Change subject: IMPALA-11834: Error reporting addendum ...................................................................... Patch Set 2: (1 comment) Thank you for the review Daniel! http://gerrit.cloudera.org:8080/#/c/19481/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19481/2/be/src/service/client-request-state.cc@885 PS2, Line 885: errno > Before this change we added "query_status.msg().msg()" to the status error That was actually unnecessary in L881, because the query_status is supposed to be OK on this code path. On the other code path however it is useful to add the query_status and it is appended to revert_err. Changed to GetDetail() because this method is better to get the error message from the Status object. -- To view, visit http://gerrit.cloudera.org:8080/19481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iece31fa19b7448095462671acb2f02e8c5a405ae Gerrit-Change-Number: 19481 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Feb 2023 08:11:32 +0000 Gerrit-HasComments: Yes
