Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18705 )
Change subject: IMPALA-11417: Support outer join elimination optimization ...................................................................... Patch Set 11: (2 comments) > Patch Set 9: > > Please provide more context on the actual queries and table sizes you are > targeting along with some performance measurements with and without this > optimization. Hi Kurt, take the 'tpcds. inventory' table as an example: the performance measurements result: https://issues.apache.org/jira/secure/attachment/13055252/performance_compare.txt http://gerrit.cloudera.org:8080/#/c/18705/9/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/18705/9/common/thrift/Query.thrift@602 PS9, Line 602: 149: optional bool trust_pk_fk_constraints = false > I think that this should be false by default, otherwise this is a potential Done in patch 11 http://gerrit.cloudera.org:8080/#/c/18705/6/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test File testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test: http://gerrit.cloudera.org:8080/#/c/18705/6/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test@1 PS6, Line 1: # Test Case Summary: > Can you add some simple EE tests too? e.g. on of the planner tests in https Done in patch 11. -- To view, visit http://gerrit.cloudera.org:8080/18705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e68263a029ac84a4f35b0846b22aa42d7ceece Gerrit-Change-Number: 18705 Gerrit-PatchSet: 11 Gerrit-Owner: Jian Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Wed, 08 Feb 2023 12:08:23 +0000 Gerrit-HasComments: Yes
