Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19483 )
Change subject: [WIP] IMPALA-11908: Parser change for Iceberg metadata querying ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19483/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19483/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@414 PS1, Line 414: for (Column col : IcebergSchemaConverter.convertToImpalaSchema(getIcebergSchema())) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19483/1/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergMetadataTable.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergMetadataTable.java: http://gerrit.cloudera.org:8080/#/c/19483/1/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergMetadataTable.java@55 PS1, Line 55: for (Column col : IcebergSchemaConverter.convertToImpalaSchema(metadataTableSchema)) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19483/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19483/1/tests/query_test/test_iceberg.py@1006 PS1, Line 1006: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/19483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b5db884b5f3fecbd132fcb2c2cbd6c622ff965b Gerrit-Change-Number: 19483 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Feb 2023 14:46:39 +0000 Gerrit-HasComments: Yes
