Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )
Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Good idea! http://gerrit.cloudera.org:8080/#/c/19487/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19487/1//COMMIT_MSG@10 PS1, Line 10: now uses nit: "used" would be more clear in my opinion, since it describes the previous implementation. -- To view, visit http://gerrit.cloudera.org:8080/19487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019 Gerrit-Change-Number: 19487 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Feb 2023 10:34:11 +0000 Gerrit-HasComments: Yes
