Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19033 )

Change subject: IMPALA-11604 Planner changes for CPU usage
......................................................................


Patch Set 47:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/19033/46//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19033/46//COMMIT_MSG@149
PS46, Line 149: further in step IV.
              :
              : Take an example of the following fragment plan.
              :
              :   F03:PLAN FRAGMENT [HASH(i_class)] hosts=3 instances=3
              :   fragment-costs=[34550429, 2159270, 23752870, 1]
              :   08:TOP-N [LIMIT=100]
              :   |  cost=900
              :   |
              :   07:ANALYTIC
              :   |  cost=23751970
              :   |
              :   06:SORT
              :   |  cost=2159270
              :   |
              :   12:AGGREGA
> nit. Indentation can help readability.
Done


http://gerrit.cloudera.org:8080/#/c/19033/46//COMMIT_MSG@190
PS46, Line 190: ing algorithm recursively walks, bottom-up, all PlanFragments in
              : the q
> See my comment on the removal of the list of processingCost above.
Done


http://gerrit.cloudera.org:8080/#/c/19033/46//COMMIT_MSG@206
PS46, Line 206: overlapping between fragment execution and blocking operators. 
We
              : compute this in a similar recursive walk as step III and split 
the query
              : tree into blocking fragment subtrees similar to step II. The 
following
              : is an example of a query plan from TPCDS-Q12.
              :
              :   F04:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1
              :   PLAN-ROOT SINK
              :   |
              :   13:MERGING-EXCHANGE [UNPARTITIONED]
              :   |
              :   F03:PLAN FRAGMENT [HASH(i_class)] hosts=3 instances=3 
(adjusted from 12)
              :   08:TOP-N [LIMIT=100]
              :   |
              :   07:ANALYTIC
              :   |
              :   06:SORT
              :   |
              :   12:AGGREGATE [FINALIZE]
              :   |
              :   11:EXCHANGE [HASH(i_class)]
              :   |
              :   F00:PLAN FRAGMENT [RANDOM] hosts=3 instances=12
              :   05:AGGREGATE [STREAMING]
              :   |
              :   04:HASH JOIN [INNER JOIN, BROADCAST]
              :   |
              :   |--F05:PLAN FRAGMENT [RANDOM] hosts=3 instances=3
              :   |  JOIN BUILD
              :   |  |
              :   |  10:EXCHANGE [BROADCAST]
              :   |  |
              :   |  F02:PLAN FRAGMENT [RANDOM] hosts=1 instances=1
              :   |  02:SCAN HDFS [tpcds10_parquet.date_dim, RANDOM]
              :   |
              :   03:HASH JOIN [INNER JOIN, BROADCAST]
              :   |
              :   |--F06:PLAN FRAGMENT [RANDOM] hosts=3 instances=3
              :   |  JOIN BUILD
              :   |  |
              :   |  09:EXCHANGE [BROADCAST]
> nit indentation.
Done


http://gerrit.cloudera.org:8080/#/c/19033/46//COMMIT_MSG@253
PS46, Line 253: he query
> The order is flipped here.
Done



--
To view, visit http://gerrit.cloudera.org:8080/19033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a
Gerrit-Change-Number: 19033
Gerrit-PatchSet: 47
Gerrit-Owner: Qifan Chen <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 13 Feb 2023 21:18:39 +0000
Gerrit-HasComments: Yes

Reply via email to