Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19471 )
Change subject: IMPALA-11081: Fix incorrect results in partition key scan ...................................................................... Patch Set 13: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/19471/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19471/13//COMMIT_MSG@14 PS13, Line 14: , nit: "," -> "." http://gerrit.cloudera.org:8080/#/c/19471/13//COMMIT_MSG@15 PS13, Line 15: only read footers for Parquet/ORC files nit: "backends only issue footer ranges for Parquet/ORC files for file-metadata-only queries (see HdfsScanner::IssueFooterRanges())". http://gerrit.cloudera.org:8080/#/c/19471/13/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/19471/13/tests/common/test_dimensions.py@32 PS13, Line 32: FILE_FORMAT_MAP nit: FILE_FORMAT_TO_STORED_AS_MAP or FILE_FORMAT_TO_STORED_AS seems more clear -- To view, visit http://gerrit.cloudera.org:8080/19471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17331ed6c26a747e0509dcbaf427cd52808943b1 Gerrit-Change-Number: 19471 Gerrit-PatchSet: 13 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 14 Feb 2023 01:19:19 +0000 Gerrit-HasComments: Yes
