Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19496 )
Change subject: IMPALA-11920: Support spill to HDFS address by service ID ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/19496/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19496/3//COMMIT_MSG@17 PS3, Line 17: priority > Just to confirm that the priority is removed in the document for the remote Yes, it'll still be parsed in the code. http://gerrit.cloudera.org:8080/#/c/19496/3/be/src/runtime/tmp-file-mgr-test.cc File be/src/runtime/tmp-file-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/19496/3/be/src/runtime/tmp-file-mgr-test.cc@2240 PS3, Line 2240: hdfs > Maybe it is not related, but when I test with a space behind the url like - Ok. That happens because https://github.com/apache/impala/blob/feb4a76ed4cb5b688143eb21370f78ec93133c56/be/src/runtime/tmp-file-mgr.cc#L290 only does trim left. trim_copy would be fine there. http://gerrit.cloudera.org:8080/#/c/19496/3/docs/topics/impala_disk_space.xml File docs/topics/impala_disk_space.xml: http://gerrit.cloudera.org:8080/#/c/19496/3/docs/topics/impala_disk_space.xml@298 PS3, Line 298: /dir1::0 > The alignment looks weird compared to the previous version, does this part It fixes the indentation in https://impala.apache.org/docs/build/asf-site-html/topics/impala_disk_space.html. All whitespace is included in a codeblock, and having the examples indented looks wrong to me. http://gerrit.cloudera.org:8080/#/c/19496/3/docs/topics/impala_disk_space.xml@486 PS3, Line 486: ozone1 > Just a question that what is the difference between Ozone service identifie Ozone Manager might be addressed via a hostname. https://ci-hadoop.apache.org/view/Hadoop%20Ozone/job/ozone-doc-master/lastSuccessfulBuild/artifact/hadoop-hdds/docs/public/feature/om-ha.html discusses service IDs for an HA deployment. http://gerrit.cloudera.org:8080/#/c/19496/3/docs/topics/impala_disk_space.xml@488 PS3, Line 488: > nit. looks good to have a comma here Ack -- To view, visit http://gerrit.cloudera.org:8080/19496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie069cba211df85fe90d174900b20a26fcc1f7167 Gerrit-Change-Number: 19496 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Feb 2023 17:50:06 +0000 Gerrit-HasComments: Yes
