Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19503 )

Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default.
......................................................................


Patch Set 4:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java
File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:

http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@393
PS4, Line 393:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@441
PS4, Line 441:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@452
PS4, Line 452:     Path logDir = 
Files.createTempDirectory("testJwtAuthWithTrustedJwksHttpsUrlInvalidCN");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java
File fe/src/test/java/org/apache/impala/testutil/X509CertChain.java:

http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@51
PS4, Line 51:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@56
PS4, Line 56:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@67
PS4, Line 67:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@111
PS4, Line 111:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@126
PS4, Line 126:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@140
PS4, Line 140:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@202
PS4, Line 202:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@211
PS4, Line 211:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19503/4/fe/src/test/java/org/apache/impala/testutil/X509CertChain.java@245
PS4, Line 245:
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/19503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1e887fae39b5fb82fa9a40352e4b507b7d8d35
Gerrit-Change-Number: 19503
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Tue, 21 Feb 2023 02:56:51 +0000
Gerrit-HasComments: Yes

Reply via email to