Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19029 )
Change subject: IMPALA-11606: Add the 'mem-tracker.process.bytes-untracked' metric. ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/19029/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19029/9//COMMIT_MSG@10 PS9, Line 10: it's : children Should be something like "but not by its children". http://gerrit.cloudera.org:8080/#/c/19029/9//COMMIT_MSG@11 PS9, Line 11: , it Could be a full stop (.) and start a new sentence. http://gerrit.cloudera.org:8080/#/c/19029/9//COMMIT_MSG@11 PS9, Line 11: when continue increasing Nit: when it continues to increase. http://gerrit.cloudera.org:8080/#/c/19029/9/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/19029/9/be/src/runtime/mem-tracker.cc@260 PS9, Line 260: WARN Nit: "WARNING" would be better. http://gerrit.cloudera.org:8080/#/c/19029/9/be/src/runtime/mem-tracker.cc@402 PS9, Line 402: TODO Let's not forget that this should be resolved before merging this change :) http://gerrit.cloudera.org:8080/#/c/19029/9/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/19029/9/common/thrift/metrics.json@2043 PS9, Line 2043: but it's children but not by its children -- To view, visit http://gerrit.cloudera.org:8080/19029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib16e00109d732f759c96c7a967eb1cc32124a03f Gerrit-Change-Number: 19029 Gerrit-PatchSet: 9 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Thu, 23 Feb 2023 12:38:30 +0000 Gerrit-HasComments: Yes
