Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19532 )
Change subject: IMPALA-11904: Data cache support dumping for reloading ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.h File be/src/runtime/io/data-cache.h: http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.h@496 PS1, Line 496: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc@204 PS1, Line 204: kudu::Env::Default()->NewRWFile(opts, path, &cache_file->file_), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc@484 PS1, Line 484: string key; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc@487 PS1, Line 487: /// cache file. When we dump the cache metadata, the ‘file_’ is meaningless because line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc@683 PS1, Line 683: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc@1037 PS1, Line 1037: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/data-cache.cc@1284 PS1, Line 1284: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/disk-io-mgr.h@417 PS1, Line 417: /// Try to dump the data of remote data cache to disk, so it could be loaded when line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/runtime/io/disk-io-mgr.cc@78 PS1, Line 78: DEFINE_bool(data_cache_enable_dumping, false, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/util/cache/lirs-cache.cc@1086 PS1, Line 1086: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/util/cache/lirs-cache.cc@1105 PS1, Line 1105: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19532/1/be/src/util/cache/lirs-cache.cc@1125 PS1, Line 1125: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/19532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id867f4fc7343898e4906332c3caa40eb57a03101 Gerrit-Change-Number: 19532 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 08:09:24 +0000 Gerrit-HasComments: Yes
