Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 )
Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19530/2/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/19530/2/docs/topics/impala_iceberg.xml@614 PS2, Line 614: content Nit: contents? http://gerrit.cloudera.org:8080/#/c/19530/2/docs/topics/impala_iceberg.xml@639 PS2, Line 639: In the two cases above we started a new line after the title (in <codeph>), from here on we don't. It would be better if it was consistent. http://gerrit.cloudera.org:8080/#/c/19530/2/docs/topics/impala_iceberg.xml@659 PS2, Line 659: HadoopCatalog and HiveCatalog Shouldn't it be HadoopCatalogs and HiveCatalogs, i.e. plural? -- To view, visit http://gerrit.cloudera.org:8080/19530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd761a81f5c81a25a5ec0889402f85157c23e9fe Gerrit-Change-Number: 19530 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 13:36:36 +0000 Gerrit-HasComments: Yes
