Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 )
Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19536/5/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java: http://gerrit.cloudera.org:8080/#/c/19536/5/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@443 PS5, Line 443: List<String> logLines = null; : Matcher<Iterable<? super String>> m = hasItem(containsString(expectedErrString)); : : // writing logs to disk may take some time, try a few times to search for the : // expected error in the log : for (int i=0; i<10; i++) { : logLines = Files.readAllLines(logDir.resolve("impalad.ERROR")); : if (m.matches(logLines)) { : break; : } : Thread.sleep(250); : } : : // runs the matcher one more time to ensure a descriptive failure message is : // generated if the assert fails > nit: This code is duplicated in two places. Maybe put this into its own met Done -- To view, visit http://gerrit.cloudera.org:8080/19536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26d8c2cffa7bc095b81eb572709f55b04ac1fa67 Gerrit-Change-Number: 19536 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 25 Feb 2023 01:04:11 +0000 Gerrit-HasComments: Yes
