Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 )
Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19506/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/19506/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@690 PS2, Line 690: Sets the filter size (in bytes) based on the filter type Is this stamement still true after changing the method signature? http://gerrit.cloudera.org:8080/#/c/19506/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@772 PS2, Line 772: // We only enforce a limit on the number of bloom filters as they are much more : // heavy-weight than the other filter types. nit: Looks like we also limit IN-LIST filter in the following loop. Maybe update this comment to mention that? -- To view, visit http://gerrit.cloudera.org:8080/19506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa46789663cb2e6d29f518757d89c85ff8e4d1a Gerrit-Change-Number: 19506 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 17:10:19 +0000 Gerrit-HasComments: Yes
